Skip to content

Titleize windows type short_names#1333

Merged
maebeale merged 2 commits intomainfrom
maebeale/titleize-windows-type-names
Mar 8, 2026
Merged

Titleize windows type short_names#1333
maebeale merged 2 commits intomainfrom
maebeale/titleize-windows-type-names

Conversation

@maebeale
Copy link
Collaborator

@maebeale maebeale commented Mar 3, 2026

What is the goal of this PR and why is this important?

  • Windows type short_names were stored as all-caps (ADULT, CHILDREN, COMBINED) which looked harsh in the UI
  • Production data has already been updated to title case — this aligns the codebase to match

How did you approach the change?

  • Updated db/seeds.rb and db/seeds/dummy_dev_seeds.rb
  • Updated controller lookups that reference short_name by string (e.g. find_by(short_name: "Adult"))
  • Updated rake task (story_data.rake)
  • Updated factory traits (:adult, :children, :combined)
  • Updated view specs, request specs, system tests, and model spec expectations

UI Testing Checklist

  • Verify windows type names display as "Adult", "Children", "Combined" (not all-caps) across the app
  • Run seeds successfully: bin/rails db:seed
  • All specs pass: bundle exec rspec

Anything else to add?

  • No migration needed — production data was already updated directly
  • This is a codebase alignment change to match what's already in production

🤖 Generated with Claude Code

@maebeale maebeale force-pushed the maebeale/titleize-windows-type-names branch from c4c4d7c to fdf5208 Compare March 4, 2026 10:45
@maebeale maebeale changed the title Titleize windows type short_names HOLD: Titleize windows type short_names Mar 4, 2026
@maebeale maebeale changed the title HOLD: Titleize windows type short_names Titleize windows type short_names Mar 8, 2026
ADULT → Adult, CHILDREN → Children, COMBINED → Combined.
Updates seeds, factories, controller lookups, rake tasks, and specs
to match production data.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@maebeale maebeale force-pushed the maebeale/titleize-windows-type-names branch from fdf5208 to efb148a Compare March 8, 2026 13:16
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@maebeale maebeale merged commit f96a98a into main Mar 8, 2026
5 of 7 checks passed
@maebeale maebeale deleted the maebeale/titleize-windows-type-names branch March 8, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant